linux-kernel - Re: [PATCH] scsi: ufs: core: Fix build error: ufshcd_opp_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231012073955.GA14957@thinkpad>
Date:   Thu, 12 Oct 2023 13:09:55 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     "Alessandro Carminati (Red Hat)" <alessandro.carminati@...il.com>
Cc:     alim.akhtar@...sung.com, andersson@...nel.org, avri.altman@....com,
        bmasney@...hat.com, bvanassche@....org, conor+dt@...nel.org,
        cw00.choi@...sung.com, devicetree@...r.kernel.org,
        jejb@...ux.ibm.com, konrad.dybcio@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org,
        kyungmin.park@...sung.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
        myungjoo.ham@...sung.com, nm@...com, quic_asutoshd@...cinc.com,
        quic_bhaskarv@...cinc.com, quic_cang@...cinc.com,
        quic_narepall@...cinc.com, quic_nguyenb@...cinc.com,
        quic_nitirawa@...cinc.com, quic_richardp@...cinc.com,
        quic_ziqichen@...cinc.com, robh+dt@...nel.org, sboyd@...nel.org,
        vireshk@...nel.org
Subject: Re: [PATCH] scsi: ufs: core: Fix build error: ufshcd_opp_config_clks

On Thu, Oct 12, 2023 at 07:20:51AM +0000, Alessandro Carminati (Red Hat) wrote:
> Building linux-6.6-rc3 with this patchset applied and the following
> configuration:
> 
> CONFIG_SCSI_UFSHCD=m
> CONFIG_SCSI_UFS_BSG=y
> 
> I got:
> 
>    scripts/mod/modpost -M -m -a      -o Module.symvers -T modules.order vmlinux.o
> ERROR: modpost: "ufshcd_opp_config_clks" [drivers/ufs/host/ufshcd-pltfrm.ko] undefined!
> make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1
> make[1]: *** [/home/alessandro/src/linux-6.6-rc3/Makefile:1865: modpost] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
> 
> I needed to add an export symbol to have the build complete
> 
> Signed-off-by: Alessandro Carminati (Red Hat) <alessandro.carminati@...il.com>

Thanks for the diff. I will squash it with the offending patch.

- Mani

> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index ccd7fcd18355..c0631c37c3d1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -1098,6 +1098,7 @@ int ufshcd_opp_config_clks(struct device *dev, struct opp_table *opp_table,
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(ufshcd_opp_config_clks);
>  
>  static int ufshcd_opp_set_rate(struct ufs_hba *hba, unsigned long freq)
>  {
> -- 
> 2.34.1
> 

-- 
மணிவண்ணன் சதாசிவம்