[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <625f462e-d0d9-4abd-87db-178674f02cb9@ti.com>
Date: Thu, 12 Oct 2023 14:48:57 +0530
From: Vignesh Raghavendra <vigneshr@...com>
To: MD Danish Anwar <danishanwar@...com>, Nishanth Menon <nm@...com>
CC: Peng Fan <peng.fan@....com>, Udit Kumar <u-kumar1@...com>,
NĂcolas F. R. A. Prado
<nfraprado@...labora.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Arnd Bergmann <arnd@...db.de>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Bjorn Andersson <quic_bjorande@...cinc.com>,
Will Deacon <will@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
Tero Kristo <kristo@...nel.org>, <linux-omap@...r.kernel.org>,
<srk@...com>, <r-gunasekaran@...com>
Subject: Re: [PATCH v4 0/4] Add AM65x ICSSG Ethernet support
On 03/10/23 16:25, MD Danish Anwar wrote:
> Hi All,
>
> This series adds support for ICSSG ethernet on AM65x SR2.0.
> This series also enables TI_ICSSG_PRUETH as loadable kernel module.
> This series is based on the latest next-20230925 linux-next.
>
> This is the v4 of the series [v1]. This addresses comments made on v3.
>
> Changes from v3 to v4:
> *) Added RB tag of Andrew Davis.
> *) Added LAKML to the --cc of this series as it was dropped in v3.
>
> Changes from v2 to v3:
> *) Changed comment of icssg nodes in device trees from "Dual Ethernet
> application node" to "Ethernet node" as asked by Andrew L.
> *) Applied k3-am654-idk.dtbo at build time to the k3-am654-base-board.dtb
> in order to not have orphan DTBO as asked by Andrew D.
> *) Modified k3-am654-gp-evm.dtb to have k3-am654-icssg2.dtbo as well.
>
> Changes from v1 to v2:
> *) Moved ICSSG2 nodes from k3-am654-base-board.dts to new overlay file
> k3-am654-icssg2.dtso as asked by Andrew.
> *) Renamed k3-am654-base-board.dts to k3-am654-common-board.dts
> *) Added "Enable TI_ICSSG_PRUETH" patch to this series.
>
> [v1] https://lore.kernel.org/all/20230911071245.2173520-1-danishanwar@ti.com/
> [v2] https://lore.kernel.org/all/20230921060913.721336-1-danishanwar@ti.com/
> [v3] https://lore.kernel.org/all/20230926045337.1248276-1-danishanwar@ti.com/
>
Wit this series applied I see build failures like:
arch/arm64/boot/dts/ti/k3-am65-main.dtsi:897.25-916.4: Warning (unique_unit_address): /bus@...000/pcie@...0000: duplicate unit-address (also used in node /bus@...000/pcie-ep@...0000)
DTC arch/arm64/boot/dts/ti/k3-am654-icssg2.dtbo
arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:14.6-85.3: Warning (node_name_chars_strict): /fragment@..._overlay__: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:87.12-125.3: Warning (node_name_chars_strict): /fragment@..._overlay__: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso:127.14-145.3: Warning (node_name_chars_strict): /fragment@..._overlay__: Character '_' not recommended in node name
DTOVL arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
Overlay 'arch/arm64/boot/dts/ti/k3-am654.dtsi' is incomplete (4096 / 1346656301 bytes read)
make[3]: *** [scripts/Makefile.lib:402: arch/arm64/boot/dts/ti/k3-am654-base-board.dtb] Error 1
make[2]: *** [scripts/Makefile.build:480: arch/arm64/boot/dts/ti] Error 2
make[1]: *** [/home/a0132425/workspace/k3-next/Makefile:1391: dtbs] Error 2
make: *** [Makefile:234: __sub-make] Error 2
There probably is some race here as I see this with make -j32 dtbs
but not on my less powerful laptop
> Thanks and Regards,
> MD Danish Anwar
>
> MD Danish Anwar (4):
> arm64: dts: ti: k3-am65-main: Add ICSSG IEP nodes
> arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support
> arm64: dts: ti: k3-am654-idk: Add ICSSG Ethernet ports
> arm64: defconfig: Enable TI_ICSSG_PRUETH
>
> arch/arm64/boot/dts/ti/Makefile | 4 +
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 36 +++
> ...se-board.dts => k3-am654-common-board.dts} | 0
> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 145 +++++++++
> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 296 ++++++++++++++++++
> arch/arm64/configs/defconfig | 1 +
> 6 files changed, 482 insertions(+)
> rename arch/arm64/boot/dts/ti/{k3-am654-base-board.dts => k3-am654-common-board.dts} (100%)
> create mode 100644 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> create mode 100644 arch/arm64/boot/dts/ti/k3-am654-idk.dtso
>
--
Regards
Vignesh
Powered by blists - more mailing lists