linux-kernel - Re: [PATCH] media: cec: meson: always include meson sub-directory in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <788e7ae5-1560-4f6f-b6b8-930ce6a9cedb@xs4all.nl>
Date:   Thu, 12 Oct 2023 12:42:23 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-amlogic@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] media: cec: meson: always include meson sub-directory in
 Makefile

On 10/12/23 12:35, Marek Szyprowski wrote:
> 'meson' directory contains two separate drivers, so it should be added
> to Makefile compilation hierarchy unconditionally, because otherwise the
> meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>

Does this need a Fixes tag?

Regards,

	Hans

> ---
>  drivers/media/cec/platform/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/cec/platform/Makefile b/drivers/media/cec/platform/Makefile
> index 26d2bc778394..a51e98ab4958 100644
> --- a/drivers/media/cec/platform/Makefile
> +++ b/drivers/media/cec/platform/Makefile
> @@ -6,7 +6,7 @@
>  # Please keep it in alphabetic order
>  obj-$(CONFIG_CEC_CROS_EC) += cros-ec/
>  obj-$(CONFIG_CEC_GPIO) += cec-gpio/
> -obj-$(CONFIG_CEC_MESON_AO) += meson/
> +obj-y += meson/
>  obj-$(CONFIG_CEC_SAMSUNG_S5P) += s5p/
>  obj-$(CONFIG_CEC_SECO) += seco/
>  obj-$(CONFIG_CEC_STI) += sti/