linux-kernel - Re: [Patch v2 2/2] memory: tegra: set BPMP msg flags to reset IPC channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSfR1l3lHMScTyL9@orome.fritz.box>
Date:   Thu, 12 Oct 2023 13:00:38 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Sumit Gupta <sumitg@...dia.com>, krzysztof.kozlowski@...aro.org
Cc:     treding@...dia.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        bbasu@...dia.com
Subject: Re: [Patch v2 2/2] memory: tegra: set BPMP msg flags to reset IPC
 channels

On Mon, Oct 09, 2023 at 03:35:57PM +0530, Sumit Gupta wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> Set the 'TEGRA_BPMP_MESSAGE_RESET' bit in newly added 'flags' field
> of 'struct tegra_bpmp_message' to request for the reset of BPMP IPC
> channels. This is used along with the 'suspended' check in BPMP driver
> for handling early bandwidth requests due to the hotplug of CPU's
> during system resume before the driver gets resumed.
> 
> Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
> Signed-off-by: Thierry Reding <treding@...dia.com>
> Co-developed-by: Sumit Gupta <sumitg@...dia.com>
> Signed-off-by: Sumit Gupta <sumitg@...dia.com>
> ---
>  drivers/memory/tegra/tegra234.c | 4 ++++
>  1 file changed, 4 insertions(+)

Krzysztof,

this one has a build-time dependency on patch 1/2, so it'd make sense
for me to pick this up into the Tegra tree along with patch 1/2. That
is slightly easier because I already have a BPMP patch in the tree.

There should be no conflict between this and the Tegra tree, though,
so if you feel strongly about it, you could also pick up both patches,
in which case:

Acked-by: Thierry Reding <treding@...dia.com>

> 
> diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra234.c
> index 9e5b5dbd9c8d..2845041f32d6 100644
> --- a/drivers/memory/tegra/tegra234.c
> +++ b/drivers/memory/tegra/tegra234.c
> @@ -986,6 +986,10 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)
>  	msg.rx.data = &bwmgr_resp;
>  	msg.rx.size = sizeof(bwmgr_resp);
>  
> +	if (pclient->bpmp_id >= TEGRA_ICC_BPMP_CPU_CLUSTER0 &&
> +	    pclient->bpmp_id <= TEGRA_ICC_BPMP_CPU_CLUSTER2)
> +		msg.flags = TEGRA_BPMP_MESSAGE_RESET;
> +
>  	ret = tegra_bpmp_transfer(mc->bpmp, &msg);
>  	if (ret < 0) {
>  		dev_err(mc->dev, "BPMP transfer failed: %d\n", ret);
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)