linux-kernel - Re: [PATCH] tty: serial: meson: hard LOCKUP on crtscts mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF69FF15CB.37BD077D-ON00258A46.0044809B-00258A46.004530FF@gdc.ru>
Date:   Thu, 12 Oct 2023 12:35:45 +0000
From:   pkrasavin@...qliq.ru
To:     "Dmitry Rokosov" <ddrokosov@...utedevices.com>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Jiri Slaby" <jirislaby@...nel.org>,
        "Neil Armstrong" <neil.armstrong@...aro.org>,
        "Kevin Hilman" <khilman@...libre.com>,
        "Jerome Brunet" <jbrunet@...libre.com>,
        "Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
        <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <kernel@...rdevices.ru>,
        <linux-amlogic@...ts.infradead.org>
Subject: Re: [PATCH] tty: serial: meson: hard LOCKUP on crtscts mode

Hello Dmitry,

----- "Dmitry Rokosov" <ddrokosov@...utedevices.com> писал(а): -----

> Please do not use braces where is single statement. In other words:
> 
> 	if (cflags & CRTSCTS) {
> 		if (port->flags & UPF_HARD_FLOW)
> 			val &= ~AML_UART_TWO_WIRE_EN;
> 		else
> 			termios->c_cflag &= ~CRTSCTS;
> 	} else {
> 		val |= AML_UART_TWO_WIRE_EN;
> 	}


thank you for your note, I will provide v2 without braces.

--
Regards,
Pavel.