linux-kernel - Re: [PATCH] drm/tidss: Power up attached PM domains on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <libnfyaftywmfr2gmkdjsv6cptzjyrrx2tkxczusifnwthyh36@olzd2e5hagtr>
Date:   Thu, 12 Oct 2023 14:40:56 +0200
From:   Maxime Ripard <mripard@...nel.org>
To:     Devarsh Thakkar <devarsht@...com>
Cc:     jyri.sarha@....fi, tomi.valkeinen@...asonboard.com,
        airlied@...il.com, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        praneeth@...com, nm@...com, vigneshr@...com, a-bhatia1@...com,
        j-luthra@...com, r-ravikumar@...com, j-choudhary@...com
Subject: Re: [PATCH] drm/tidss: Power up attached PM domains on probe

Hi,

On Thu, Oct 12, 2023 at 05:10:06PM +0530, Devarsh Thakkar wrote:
> On 09/10/23 13:20, Devarsh Thakkar wrote:
> > Some SoC's such as AM62P have dedicated power domains
> > for OLDI which need to be powered on separetely along
> > with display controller.
> > 
> > So during driver probe, power up all attached PM domains
> > enumerated in devicetree node for DSS.
> > 
> > This also prepares base to add display support for AM62P.
> > 
> 
> NAK, for this patch, as discussed with team there are already plans
> to have separate OLDI bridge driver which should eventually handle
> the additional power domains.

Just for the record in case your current plan doesn't work out and we
need to revisit this patch: my point was that it's something that
deviates by a margin from what drivers are usually expected to do, so we
should document why that deviation is there.

The patch itself looks reasonable to me otherwise.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)