linux-kernel - Re: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdyJjkyPJH6nd2NKTNee5nnXyN3HJ4fvJXwp6pRm9Da+A@mail.gmail.com>
Date:   Thu, 12 Oct 2023 15:23:43 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers

On Thu, Oct 12, 2023 at 9:08 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Wed, Oct 11, 2023 at 2:09 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > We have a set of pinctrl helpers for GPIOLIB drivers that take a number
> > from the global GPIO numberspace as argument. We are trying to get rid
> > of this global numbering. Let's rework these helpers to use the
> > recommended gpio_chip + controller-relative offset instead.
> >
> > This work is split into phases: first let's introduce the new variants
> > of the helpers. Next: let's convert all users one-by-one for easier
> > review. After that let's remove the old helpers and rename the new
> > variants to take the place of the old ones. Finally convert static
> > functions in pinctrl/core.c to using the same signature and to top it
> > off, let's remove now redundant wrappers around the pinctrl_helpers.
> >
> > This series introduces no functional changes in drivers so I decided to
> > not spam every single driver maintainer anymore.
> >
> > v1 -> v2:
> > - drop the conversion to using cleanup.h helpers as this is not the
> >   subject of this series
> > - split the patch renaming the new variants to the old names into
> >   several patches that perform the operation step by step for easier
> >   review
> > - collect review tags and acks
> > - add follow-up patches that drop the wrappers around pinctrl helpers
> >   where applicable (where all the wrappers do is call the helper)
> > - fix build error with PINCTRL disabled
>
> I tried to apply the series for a test, with the intent to queue this for
> v6.7, but there are conflicts toward both v6.6-rc1 and my pin control
> devel branch, so I can't.
>
> Since we are at -rc5 and the kernel looks better after the patches
> than before I think they should just be applied and not held back
> by minor review nits or process. But i couldn't.
>
> I'm fine with the series as they are, but it looks like we need to queue
> it at v6.7-rc1 for v6.8 or you need to send it to Torvalds after he
> merged GPIO and pin control for v6.7, either works for me!
>

Sounds good, just please make sure to send your pinctrl PR early in
the merge window.

Thanks,
Bartosz