[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2d6fae5-ace7-4b94-9354-a01cd6a7e343@linaro.org>
Date: Thu, 12 Oct 2023 16:27:46 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Zhang Rui <rui.zhang@...el.com>,
Lukasz Luba <lukasz.luba@....com>
Subject: Re: [PATCH v1 1/6] thermal: trip: Simplify computing trip indices
On 06/10/2023 19:40, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> A trip index can be computed right away as a difference between the
> value of a trip pointer pointing to the given trip object and the
> start of the trips[] table in the thermal zone containing the trip, so
> change thermal_zone_trip_id() accordingly.
>
> No intentional functional impact (except for some speedup).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> drivers/thermal/thermal_trip.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> Index: linux-pm/drivers/thermal/thermal_trip.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_trip.c
> +++ linux-pm/drivers/thermal/thermal_trip.c
> @@ -175,14 +175,11 @@ int thermal_zone_set_trip(struct thermal
> int thermal_zone_trip_id(struct thermal_zone_device *tz,
> const struct thermal_trip *trip)
> {
> - int i;
> -
> lockdep_assert_held(&tz->lock);
>
> - for (i = 0; i < tz->num_trips; i++) {
> - if (&tz->trips[i] == trip)
> - return i;
> - }
> -
> - return -ENODATA;
> + /*
> + * Assume the trip to be located within the bounds of the thermal
> + * zone's trips[] table.
> + */
> + return trip - tz->trips;
Shouldn't be divided by sizeof(*trip) ?
> }
>
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists