[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6529727e18964_f879294ea@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Date: Fri, 13 Oct 2023 09:38:22 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Michal Wilczynski <michal.wilczynski@...el.com>,
<nvdimm@...ts.linux.dev>, <linux-acpi@...r.kernel.org>,
<dan.j.williams@...el.com>
CC: <rafael@...nel.org>, <vishal.l.verma@...el.com>, <lenb@...nel.org>,
<dave.jiang@...el.com>, <ira.weiny@...el.com>,
<linux-kernel@...r.kernel.org>,
Michal Wilczynski <michal.wilczynski@...el.com>,
Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2] ACPI: NFIT: Fix local use of devm_*()
Michal Wilczynski wrote:
> devm_*() family of functions purpose is managing memory attached to a
> device. So in general it should only be used for allocations that should
> last for the whole lifecycle of the device.
No, this assertion is not accurate, if it were strictly true then
devm_kfree() should be deleted. This patch is only a cleanup to switch
the automatic cleanup pattern from devm to the new cleanup.h helpers.
I am all for modernizing code over time, but patches that make
assertions of "memory leaks" and "incorrect API usage" in code that has
been untouched for almost a decade demand more scrutiny than what
transpired here.
Powered by blists - more mailing lists