linux-kernel - Re: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fe01b6d8c558f11fe51f9da5fbfea6708766096.camel@perches.com>
Date:   Fri, 13 Oct 2023 11:14:47 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Andy Whitcroft <apw@...onical.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     kernel test robot <lkp@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org, rajvi.jingar@...ux.intel.com,
        oe-kbuild-all@...ts.linux.dev,
        "David E. Box" <david.e.box@...ux.intel.com>
Subject: Re: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h

On Fri, 2023-10-13 at 13:39 +0300, Ilpo Järvinen wrote:
> Hi,
> 
> I added checkpatch people, please check what looks a false positive below.

Yeah, thanks I guess.
The __free uses are very new.
I'll play around with adding it to $Attributes
and see what happens.


> On Thu, 12 Oct 2023, David E. Box wrote:
> > On Thu, 2023-10-12 at 13:25 +0800, kernel test robot wrote:
> > > kernel test robot noticed the following build warnings:
> > > # many are suggestions rather than must-fix
[]
> > > ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
> > > #31: FILE: drivers/platform/x86/intel/vsec.c:159:
> > > +       struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL;
> > 
> > These looks like false positives.
> 
> I agree. If I interpret the error message right checkpatch seems to think
> that's a multiplication which is not the case here.