linux-kernel - Re: [PATCH] perf bench sched pipe: Add -G/--cgroups option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cgAg7LfTvZhR3+Mh64GjhnLQZ6Pjae_8agMLABc0_weqg@mail.gmail.com>
Date:   Fri, 13 Oct 2023 16:20:27 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf bench sched pipe: Add -G/--cgroups option

On Fri, Oct 13, 2023 at 4:10 PM Namhyung Kim <namhyung@...nel.org> wrote:
> diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c
> index 1103fd658d5d..25236f339b90 100644
> --- a/tools/perf/bench/sched-pipe.c
> +++ b/tools/perf/bench/sched-pipe.c
> @@ -118,9 +118,9 @@ static void enter_cgroup(struct cgroup *cgrp)
>
>         /* try cgroup v2 interface first */
>         if (threaded)
> -               fd = openat(cgrp->fd, "cgroup.procs", O_WRONLY);
> -       else
>                 fd = openat(cgrp->fd, "cgroup.threads", O_WRONLY);
> +       else
> +               fd = openat(cgrp->fd, "cgroup.progs", O_WRONLY);
>
>         /* try cgroup v1 if failed */
>         if (fd < 0)

Oh, actually it should be 'procs' instead of 'progs'.

Thanks,
Namhyung