linux-kernel - [PATCH] nfsd: Clean up errors in nfs4idmap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2023 14:07:04 +0800 (GMT+08:00)
From:   chenguohua@...i.cn
To:     neilb@...e.de, kolga@...app.com, Dai.Ngo@...cle.com, tom@...pey.com
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] nfsd: Clean up errors in nfs4idmap.c

Fix the following errors reported by checkpatch:

ERROR: spaces required around that '=' (ctx:VxW)
ERROR: code indent should use tabs where possible
ERROR: return is not a function, parentheses are not required

Signed-off-by: GuoHua Cheng <chenguohua@...i.cn>
---
 fs/nfsd/nfs4idmap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
index 7a806ac13e31..4e65538a58f0 100644
--- a/fs/nfsd/nfs4idmap.c
+++ b/fs/nfsd/nfs4idmap.c
@@ -212,7 +212,7 @@ idtoname_parse(struct cache_detail *cd, char *buf, int buflen)
 
 	if (buf[buflen - 1] != '\n')
 		return (-EINVAL);
-	buf[buflen - 1]= '\0';
+	buf[buflen - 1] = '\0';
 
 	buf1 = kmalloc(PAGE_SIZE, GFP_KERNEL);
 	if (buf1 == NULL)
@@ -313,7 +313,7 @@ static void
 nametoid_request(struct cache_detail *cd, struct cache_head *ch, char **bpp,
     int *blen)
 {
- 	struct ent *ent = container_of(ch, struct ent, h);
+	struct ent *ent = container_of(ch, struct ent, h);
 
 	qword_add(bpp, blen, ent->authname);
 	qword_add(bpp, blen, ent->type == IDMAP_TYPE_GROUP ? "group" : "user");
@@ -381,7 +381,7 @@ nametoid_parse(struct cache_detail *cd, char *buf, int buflen)
 
 	if (buf[buflen - 1] != '\n')
 		return (-EINVAL);
-	buf[buflen - 1]= '\0';
+	buf[buflen - 1] = '\0';
 
 	buf1 = kmalloc(PAGE_SIZE, GFP_KERNEL);
 	if (buf1 == NULL)
@@ -431,7 +431,7 @@ nametoid_parse(struct cache_detail *cd, char *buf, int buflen)
 	error = 0;
 out:
 	kfree(buf1);
-	return (error);
+	return error;
 }
 
 
-- 
2.17.1