linux-kernel - Re: [PATCH 2/2] thermal/core: Reorder the headers inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <763f1d6d-28f0-43a7-b537-1a3229987ea3@arm.com>
Date:   Fri, 13 Oct 2023 09:05:27 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Amit Kucheria <amitk@...nel.org>, rafael@...nel.org,
        Zhang Rui <rui.zhang@...el.com>,
        "open list:THERMAL/POWER_ALLOCATOR" <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] thermal/core: Reorder the headers inclusion



On 10/12/23 11:26, Daniel Lezcano wrote:
> The next changes will move the thermal device structure inside the
> thermal core code. Consequently, the traces must be included after
> thermal_core.h as this one contains the thermal zone device structure
> definition the traces need.
> 
> Reorder the inclusions.
> 
> No functional changes intended.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>   drivers/thermal/gov_power_allocator.c | 6 +++---
>   drivers/thermal/thermal_core.c        | 6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index d1c6ad92e5b4..6056ed15460b 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -11,12 +11,12 @@
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   
> -#define CREATE_TRACE_POINTS
> -#include "thermal_trace_ipa.h"
> -
>   #define THERMAL_CORE_SUBSYS
>   #include "thermal_core.h"
>   
> +#define CREATE_TRACE_POINTS
> +#include "thermal_trace_ipa.h"


There is a small issue here to fix:

Applying: thermal/core: Reorder the headers inclusion
.git/rebase-apply/patch:21: trailing whitespace.
#include "thermal_trace_ipa.h"
warning: 1 line adds whitespace errors.

Other than that LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@....com>