linux-kernel - Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231013094113.00003d72@Huawei.com>
Date:   Fri, 13 Oct 2023 09:41:13 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Shuai Xue <xueshuai@...ux.alibaba.com>
CC:     Bjorn Helgaas <helgaas@...nel.org>, <chengyou@...ux.alibaba.com>,
        <kaishen@...ux.alibaba.com>, <yangyicong@...wei.com>,
        <will@...nel.org>, <baolin.wang@...ux.alibaba.com>,
        <robin.murphy@....com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-pci@...r.kernel.org>, <rdunlap@...radead.org>,
        <mark.rutland@....com>, <zhuo.song@...ux.alibaba.com>,
        <renyu.zj@...ux.alibaba.com>
Subject: Re: [PATCH v7 3/4] drivers/perf: add DesignWare PCIe PMU driver


> >   
> >> +	depends on (ARM64 && PCI)  
> > 
> > I don't see any actual ARM64 dependency in the code, so maybe omit
> > ARM64 (as PCIE_DW_PLAT_HOST does) or add "|| COMPILE_TEST"?  
> 
> I will remove the ARM64 dependency and add COMPILE_TEST.
don't do both.  That makes no sense. either

	depends on PCI && (ARM64 || COMPILE_TEST)
or
	depends on PCI