linux-kernel - Re: [PATCH] staging: wlan-ng: remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2023 12:02:30 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Luke Koch <lu.ale.koch@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: remove unused functions

On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> The following functions were defined in the prism2mgmt.h file but neither
> declared nor used anywhere. It is recommended that they be removed.
> 
> 	- void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> 				      struct hfa384x *priv);
> 	- int prism2mgmt_set_grpaddr(u32 did,
> 		                   u8 *prism2buf, struct p80211pstrd *pstr,
> 	                           struct hfa384x *priv);
> 	- int prism2mgmt_get_grpaddr_index(u32 did);
> 

Could you look up when the functions were deleted and add that
information to the commit message?

    These functions were removed five years ago in commit 123412341234
    ("delete functions").

regards,
dan carpenter