[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8566967beec62f50c2425551b49bb29bbd3f8405.camel@mediatek.com>
Date: Fri, 13 Oct 2023 09:25:41 +0000
From: Jian Yang (杨戬) <Jian.Yang@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"kw@...ux.com" <kw@...ux.com>,
"lpieralisi@...nel.org" <lpieralisi@...nel.org>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
Jianjun Wang (王建军)
<Jianjun.Wang@...iatek.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Jieyy Yang (杨洁) <Jieyy.Yang@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Chuanjia Liu (柳传嘉)
<Chuanjia.Liu@...iatek.com>,
Qizhong Cheng (程啟忠)
<Qizhong.Cheng@...iatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add support for
controlling power and reset
Hi Angelo,
Thanks for your comment.
On Tue, 2023-10-10 at 11:45 +0200, AngeloGioacchino Del Regno wrote:
> Il 09/10/23 10:49, Jian Yang ha scritto:
> > From: "jian.yang" <jian.yang@...iatek.com>
> >
> > Add new properties to support control power supplies and reset pin
> > of
> > a downstream component.
> >
> > Signed-off-by: jian.yang <jian.yang@...iatek.com>
> > ---
> > .../bindings/pci/mediatek-pcie-gen3.yaml | 30
> > +++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 7e8c7a2a5f9b..eb4ad98549d1 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -84,6 +84,26 @@ properties:
> > items:
> > enum: [ phy, mac ]
> >
> > + pcie1v8-supply:
>
> There are another two controllers having such regulators and they all
> have the
> same name for those supplies; Can you please change the names to be
> consistent
> with the other controllers?
>
> vpcie1v8
> vpcie3v3
> vpcie12v
>
I will rename them in next patch version.
> Regards,
> Angelo
>
>
Best regards,
Jian Yang
Powered by blists - more mailing lists