linux-kernel - Re: [PATCH] crypto: authencesn - Fix incorrect setauthsize function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSkaFmV4tfxjV3Kt@gondor.apana.org.au>
Date:   Fri, 13 Oct 2023 18:21:10 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Ingyu Jang <ingyujang25@...st.ac.kr>
Cc:     davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, ysjeon@...st.ac.kr,
        ingyujang25@...st.ac.kr
Subject: Re: [PATCH] crypto: authencesn - Fix incorrect setauthsize function

Ingyu Jang <ingyujang25@...st.ac.kr> wrote:
>
> diff --git a/crypto/authencesn.c b/crypto/authencesn.c
> index 91424e791d5c..c1346d5b7950 100644
> --- a/crypto/authencesn.c
> +++ b/crypto/authencesn.c
> @@ -52,6 +52,8 @@ static int crypto_authenc_esn_setauthsize(struct crypto_aead *authenc_esn,
>        if (authsize > 0 && authsize < 4)
>                return -EINVAL;
> 
> +       authenc_esn->authsize = authsize;
> +

The premise of this patch is incorrect.  Please check the code for
setauthsize in crypto/aead.c.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt