linux-kernel - Re: [PATCH v5] staging: wlan-ng: replace strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4679268f-63ca-4854-808a-5cb45624167b@kadam.mountain>
Date:   Fri, 13 Oct 2023 13:44:42 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Luke Koch <lu.ale.koch@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v5] staging: wlan-ng: replace strncpy() with strscpy()

On Fri, Oct 13, 2023 at 01:21:21PM +0300, Calvince Otieno wrote:
> Checkpatch suggests the use of  strscpy() instead of strncpy().
> The advantages are that it always adds a NUL terminator and it prevents
> a read overflow if the src string is not properly terminated.  One
> potential disadvantage is that it doesn't zero pad the string like
> strncpy() does.
> 
> In this code, strscpy() and strncpy() are equivalent and it does not
> affect runtime behavior.  The string is zeroed on the line before
> using memset().  The resulting string was always NUL terminated and
> PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
> terminated.
> 
> However, even though using strscpy() does not fix any bugs, it's
> still nicer and makes checkpatch happy.
> 
> Signed-off-by: Calvince Otieno <calvncce@...il.com>
> ---
> Patch version v5:
> 	Removed v1 patch details from the revsion history

This patch doesn't apply correctly.  It has been white space damaged
for some reason.  Tabs replaced with spaces.  Read
Documentation/process/email-clients.rst.  Hopefully the first paragraph
convinces you to just use git to send patchs and you can skip the rest
of the document.

I try to catch these sorts of mistakes earlier instead of making you
send a v6 but I thought the issue was the v1.  Sorry about that.  The
good news is that now you can delete the extra space character Julia
mentioned.

regards,
dan carpenter