lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5258379d69957db51c5db6f3175898f41be67fc5.camel@kernel.org>
Date:   Fri, 13 Oct 2023 06:50:16 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     chenguohua@...i.cn, trond.myklebust@...merspace.com,
        anna@...nel.org
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NFS: Clean up errors in nfs_page.h

On Fri, 2023-10-13 at 11:12 +0800, chenguohua@...i.cn wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: space required after that ',' (ctx:VxO)
> 
> Signed-off-by: JiangHui Xu <xujianghui@...rlc.com>
> ---
>  include/linux/nfs_page.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h
> index 1c315f854ea8..6a3c54bd2c40 100644
> --- a/include/linux/nfs_page.h
> +++ b/include/linux/nfs_page.h
> @@ -122,7 +122,7 @@ struct nfs_pageio_descriptor {
>  /* arbitrarily selected limit to number of mirrors */
>  #define NFS_PAGEIO_DESCRIPTOR_MIRROR_MAX 16
>  
> -#define NFS_WBACK_BUSY(req)	(test_bit(PG_BUSY,&(req)->wb_flags))
> +#define NFS_WBACK_BUSY(req)	(test_bit(PG_BUSY, &(req)->wb_flags))
>  
>  extern struct nfs_page *nfs_page_create_from_page(struct nfs_open_context *ctx,
>  						  struct page *page,

In general, we don't usually take patches that just clean up whitespace
damage or stylistic problems. Doing so makes backporting harder as you
end up having to pull in extra patches to fix up minor differences
before bringing in substantive patches.

If you're fixing a real bug in the same area, then sure, go ahead and
fix up the style in the surrounding code, but if these patches don't
fix real bugs then I'd suggest not taking them.
-- 
Jeff Layton <jlayton@...nel.org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ