linux-kernel - Re: [PATCH v5] x86/tdx: Dump TDX version During the TD Bootup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <840dab8f-f255-42b0-948b-cd740fb7d154@suse.com>
Date:   Fri, 13 Oct 2023 14:18:11 +0300
From:   Nikolay Borisov <nik.borisov@...e.com>
To:     Yi Sun <yi.sun@...el.com>, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, peterz@...radead.org,
        x86@...nel.org
Cc:     kirill.shutemov@...ux.intel.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, kai.huang@...el.com,
        linux-kernel@...r.kernel.org, heng.su@...el.com,
        yi.sun@...ux.intel.com, Dongcheng Yan <dongcheng.yan@...el.com>
Subject: Re: [PATCH v5] x86/tdx: Dump TDX version During the TD Bootup



On 12.10.23 г. 16:41 ч., Yi Sun wrote:
> It is essential for TD users to be aware of the vendor and version of
> the current TDX. Additionally, they can reference the TDX version when
> reporting bugs or issues.
> 
> Furthermore, the applications or device drivers running in TD can achieve
> enhanced reliability and flexibility by following the TDX Module ABI
> specification, because there are significant differences between different
> versions of TDX, as mentioned in the "Intel® TDX Module Incompatibilities
> between v1.0 and v1.5" reference.
> 
> Add function detect_tdx_version to fetch and dump the version of the
> TDX, which is called during TD initialization. Obtain the info by calling
> TDG.SYS.RD, including the major and minor version numbers and vendor ID.
> 
> The TDCALL TDG.SYS.RD originates from TDX version 1.5. If the error
> TDCALL_INVALID_OPERAND occurs, it should be treated as TDX version 1.0.
> 
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Co-developed-by: Dongcheng Yan <dongcheng.yan@...el.com>
> Signed-off-by: Dongcheng Yan <dongcheng.yan@...el.com>
> Signed-off-by: Yi Sun <yi.sun@...el.com>

Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>


<rant>

Intel really outdid themselves in creating the most horrendous document 
to read/comprehend aka tdx's 1.5 ABI ...

</rant>