linux-kernel - Re: [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSkoNhWDxntTbGpm@ashyti-mobl2.lan>
Date:   Fri, 13 Oct 2023 13:21:26 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Luke Koch <lu.ale.koch@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function
 prism2sta_inf_handover()

Hi Calvince,

...

> @@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
>  	/* Dispatch */
>  	switch (inf->infotype) {
>  	case HFA384x_IT_HANDOVERADDR:
> -		pr_debug("received infoframe:HANDOVER (unhandled)\n");
> +		netdev_dbg(wlandev->netdev,
> +				"received infoframe:HANDOVER (unhandled)\n");

but then you generate this:

CHECK: Alignment should match open parenthesis
#240: FILE: drivers/staging/wlan-ng/prism2sta.c:1701:
+               netdev_dbg(wlandev->netdev,
+                               "received infoframe:HANDOVER (unhandled)\n");

total: 0 errors, 0 warnings, 1 checks, 9 lines checked

:-)

Make it a habit... before sending a patch check it with
checkpatch, in order to be sure you are not introducing other
checkpatch errors.

Don't rush... take your time, check your changes carefully; use
checkpatch, compile test, run sparse, etc. Give others time to
see your patch and comment.

Andi