[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <73dd8e28-516a-4a85-a309-c411a82c958c@lunn.ch>
Date: Fri, 13 Oct 2023 14:18:18 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Justin Stitt <justinstitt@...gle.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] net: phy: replace deprecated strncpy with ethtool_sprintf
Hi Justin
The Subject line should say which PHY you are patching, nxp-cbtx. The
patches which follow do have driver names. Please repost with the
Subject corrected.
Please also take a look at
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
which will tell you about networking subsystem specific processes it
would be nice to follow.
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> ethtool_sprintf() is designed specifically for get_strings() usage.
> Let's replace strncpy in favor of this dedicated helper function.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@...r.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@...gle.com>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists