linux-kernel - Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSlQsDzNXqyRVXAf@finisterre.sirena.org.uk>
Date:   Fri, 13 Oct 2023 15:14:08 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     wangweidong.a@...nic.com, lgirdwood@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        perex@...ex.cz, tiwai@...e.com, herve.codina@...tlin.com,
        shumingf@...ltek.com, rf@...nsource.cirrus.com, arnd@...db.de,
        13916275206@....com, ryans.lee@...log.com,
        linus.walleij@...aro.org, ckeepax@...nsource.cirrus.com,
        fido_max@...ox.ru, sebastian.reichel@...labora.com,
        colin.i.king@...il.com, liweilei@...nic.com, trix@...hat.com,
        dan.carpenter@...aro.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

On Fri, Oct 13, 2023 at 01:50:41PM +0200, Krzysztof Kozlowski wrote:
> On 13/10/2023 12:42, wangweidong.a@...nic.com wrote:

> > +static void aw88399_hw_reset(struct aw88399 *aw88399)
> > +{
> > +	if (aw88399->reset_gpio) {
> > +		gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
> > +		usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
> > +		gpiod_set_value_cansleep(aw88399->reset_gpio, 1);

> Why do you leave the device in reset state? I think you wanted these
> reverted.

I imagine practical systems aren't using the inversion that gpiolib can
do via the bindings, this is already the case for the other drivers
sharing the binding.  TBH the use for things like reset lines has always
seemed like it causes more confusion and error than it solves.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)