linux-kernel - Re: [PATCH 1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+MPq=UFbAmuq3rZN0FFNAEdNj3Ju=vLE8wR_ToW3W0bVoxskg@mail.gmail.com>
Date:   Sat, 14 Oct 2023 12:40:26 +0200
From:   Jonathan Bergh <bergh.jonathan@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] drivers: usb: Fix block comments whose trailing */
 was not on a separate line

On Sun, Oct 01, 2023 at 08:06:06AM +0200, Greg KH wrote:
> On Sat, Sep 30, 2023 at 10:36:46PM +0200, Jonathan Bergh wrote:
> > Fixed various instances where block comments trailing */ where not on a
> > separate line and should be.
> >
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@...il.com>
> > ---
> >  drivers/usb/atm/cxacru.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)

Hi Greg, thanks a lot

> Your subject line for these patches is not correct, please fix up.

Thanks, will do.

> And the patches are not properly threaded, what happened in your email
> client?

Ok thanks, I used the same process as last time but will check it out.

> And finally, why make coding style changes outside of drivers/staging/?
> Did you get the maintainer's approval to do so before taking the time?
> Usually most maintainers do not want these so always ask before doing
> so, or just stick with drivers/staging/ to learn how the process works
> first please.

Ok! Thanks! Would you like these patches? I'd be happy to resend
them. Hopefully (like the guy you mentioned in your talk) unless they
screw something up, are seen as making a (postive) contribution!

cheers!
jon


> thanks,
>
> greg k-h