linux-kernel - Re: [PATCH v6 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202310150123.XoLU3dcO-lkp@intel.com>
Date:   Sun, 15 Oct 2023 02:11:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mehdi Djait <mehdi.djait@...tlin.com>, mchehab@...nel.org,
        heiko@...ech.de, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        maxime.chevallier@...tlin.com, paul.kocialkowski@...tlin.com,
        Mehdi Djait <mehdi.djait@...tlin.com>
Subject: Re: [PATCH v6 3/3] media: i2c: Introduce a driver for the Techwell
 TW9900 decoder

Hi Mehdi,

kernel test robot noticed the following build errors:

[auto build test ERROR on media-tree/master]
[also build test ERROR on robh/for-next linus/master v6.6-rc5 next-20231013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mehdi-Djait/dt-bindings-vendor-prefixes-Add-techwell-vendor-prefix/20231007-002623
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/857baa8073f0b8051720959ef8fb1d49a6161d36.1696608809.git.mehdi.djait%40bootlin.com
patch subject: [PATCH v6 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231015/202310150123.XoLU3dcO-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231015/202310150123.XoLU3dcO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310150123.XoLU3dcO-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/i2c/tw9900.c: In function 'tw9900_get_stream_std':
>> drivers/media/i2c/tw9900.c:359:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
     359 |         std = FIELD_GET(TW9900_STDNOW_MASK, ret);
         |               ^~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_GET +359 drivers/media/i2c/tw9900.c

   347	
   348	static int tw9900_get_stream_std(struct tw9900 *tw9900,
   349					 v4l2_std_id *std_id)
   350	{
   351		int std, ret;
   352	
   353		ret = tw9900_read_reg(tw9900->client, TW9900_REG_STD_SEL);
   354		if (ret < 0) {
   355			*std_id = V4L2_STD_UNKNOWN;
   356			return ret;
   357		}
   358	
 > 359		std = FIELD_GET(TW9900_STDNOW_MASK, ret);
   360	
   361		switch (std) {
   362		case TW9900_STD_NTSC_M:
   363			*std_id = V4L2_STD_NTSC;
   364			break;
   365		case TW9900_STD_PAL_BDGHI:
   366			*std_id = V4L2_STD_PAL;
   367			break;
   368		case TW9900_STD_AUTO:
   369			*std_id = V4L2_STD_UNKNOWN;
   370			break;
   371		default:
   372			*std_id = V4L2_STD_UNKNOWN;
   373			break;
   374		}
   375	
   376		return 0;
   377	}
   378	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki