linux-kernel - Re: [PATCH v4 02/17] iommu: Add nested domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSnlLuB/7SVjHRfl@Asurada-Nvidia>
Date:   Fri, 13 Oct 2023 17:47:42 -0700
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Yi Liu <yi.l.liu@...el.com>
CC:     Jason Gunthorpe <jgg@...dia.com>, <joro@...tes.org>,
        <alex.williamson@...hat.com>, <kevin.tian@...el.com>,
        <robin.murphy@....com>, <baolu.lu@...ux.intel.com>,
        <cohuck@...hat.com>, <eric.auger@...hat.com>,
        <kvm@...r.kernel.org>, <mjrosato@...ux.ibm.com>,
        <chao.p.peng@...ux.intel.com>, <yi.y.sun@...ux.intel.com>,
        <peterx@...hat.com>, <jasowang@...hat.com>,
        <shameerali.kolothum.thodi@...wei.com>, <lulu@...hat.com>,
        <suravee.suthikulpanit@....com>, <iommu@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
        <zhenzhong.duan@...el.com>, <joao.m.martins@...cle.com>
Subject: Re: [PATCH v4 02/17] iommu: Add nested domain support

On Thu, Oct 12, 2023 at 05:13:59PM +0800, Yi Liu wrote:
 
> > > @@ -241,6 +245,21 @@ struct iommu_user_data {
> > >      size_t len;
> > >   };
> > > 
> > > +/**
> > > + * struct iommu_user_data_array - iommu driver specific user space data array
> > > + * @uptr: Pointer to the user buffer array for copy_from_user()
> > > + * @entry_len: The fixed-width length of a entry in the array, in bytes
> > > + * @entry_num: The number of total entries in the array
> > > + *
> > > + * A array having a @entry_num number of @entry_len sized entries, each entry is
> > > + * user space data, i.e. an uAPI that is defined in include/uapi/linux/iommufd.h
> > > + */
> > > +struct iommu_user_data_array {
> > > +    void __user *uptr;
> > > +    size_t entry_len;
> > > +    int entry_num;
> > > +};
> > 
> > Ditto about iommu-driver.h for most of this stuff
> 
> ack.

FYI, I aligned with Jason in another conversation that we can
defer this iommu-driver.h thing since there's no more need to 
include the previous uapi header in iommu.h

Thanks
Nic