linux-kernel - Re: [PATCH v3] Input: powermate - fix use-after-free in powermate_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSoHTMQSa17OBzOw@google.com>
Date:   Fri, 13 Oct 2023 20:13:16 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+0434ac83f907a1dbdd1e@...kaller.appspotmail.com
Subject: Re: [PATCH v3] Input: powermate - fix use-after-free in
 powermate_config_complete

On Wed, Oct 04, 2023 at 04:36:13PM +0200, Javier Carrasco wrote:
> syzbot has found a use-after-free bug [1] in the powermate driver. This
> happens when the device is disconnected, which leads to a memory free
> from the powermate_device struct.
> When an asynchronous control message completes after the kfree and its
> callback is invoked, the lock does not exist anymore and hence the bug.
> 
> Use usb_kill_urb() on pm->config to cancel any in-progress requests upon
> device disconnection.
> 
> [1] https://syzkaller.appspot.com/bug?extid=0434ac83f907a1dbdd1e
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> Reported-by: syzbot+0434ac83f907a1dbdd1e@...kaller.appspotmail.com

Applied, thank you.

-- 
Dmitry