linux-kernel - Re: [PATCH v2 4/8] objtool/LoongArch: Enable orc to be built

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f31f8e9-75ad-4cb8-5998-dc9c8d00c70f@loongson.cn>
Date:   Sat, 14 Oct 2023 11:40:14 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Josh Poimboeuf <jpoimboe@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v2 4/8] objtool/LoongArch: Enable orc to be built



On 10/10/2023 08:52 PM, Huacai Chen wrote:
> Hi, Tiezhu,
>
> On Mon, Oct 9, 2023 at 9:03 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>>
>> Implement arch-specific init_orc_entry(), reg_name(), orc_type_name(),
>> print_reg() and orc_print_dump(), then set BUILD_ORC as y to build the
>> orc related files.

...

>> +#define ORC_REG_SP                     2
>> +#define ORC_REG_BP                     3
> There is no BP register for LoongArch, so I think all 'BP' should be
> 'FP' in this patch.

Makes sense, thank you, will do it.

>> +#define ORC_REG_MAX                    4

...

>> +struct orc_entry {
>> +       s16             sp_offset;
>> +       s16             bp_offset;
>> +       s16             ra_offset;
>> +       unsigned int    sp_reg:4;
>> +       unsigned int    bp_reg:4;
>> +       unsigned int    ra_reg:4;
>> +       unsigned int    type:3;
>> +       unsigned int    signal:1;
>> +};

At the same time, I will replace bp_offset with fp_offset and
replace bp_reg with fp_reg, then modify the related code.

Thanks,
Tiezhu