linux-kernel - Re: [PATCH] staging: wlan-ng: remove unnecessary helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Oct 2023 18:13:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     gustavo@...eddedor.com, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: remove unnecessary helper function

On Sun, Oct 15, 2023 at 04:12:43PM +0300, Calvince Otieno wrote:
> The function prism2sta_inf_handover() is called by the parent
> function prism2sta_ev_info() to print a literal debug information
> string using pr_debug(). The debugging utility function can be called
> directly within prism2sta_ev_info().
> 
> Furthermore, to make the debugging more module-specific, the netdev_dbg()
> function is preferred over the generic pr_debug() utility function.
> 
> Signed-off-by: Calvince Otieno <calvncce@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2sta.c | 30 ++---------------------------
>  1 file changed, 2 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index 57180bb71699..b5e95a3207fe 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -90,9 +90,6 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev);
>  static int prism2sta_globalsetup(struct wlandevice *wlandev);
>  static int prism2sta_setmulticast(struct wlandevice *wlandev,
>  				  struct net_device *dev);
> -
> -static void prism2sta_inf_handover(struct wlandevice *wlandev,
> -				   struct hfa384x_inf_frame *inf);
>  static void prism2sta_inf_tallies(struct wlandevice *wlandev,
>  				  struct hfa384x_inf_frame *inf);
>  static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev,
> @@ -922,30 +919,6 @@ static int prism2sta_setmulticast(struct wlandevice *wlandev,
>  	return result;
>  }
>  
> -/*
> - * prism2sta_inf_handover
> - *
> - * Handles the receipt of a Handover info frame. Should only be present
> - * in APs only.
> - *
> - * Arguments:
> - *	wlandev		wlan device structure
> - *	inf		ptr to info frame (contents in hfa384x order)
> - *
> - * Returns:
> - *	nothing
> - *
> - * Side effects:
> - *
> - * Call context:
> - *	interrupt
> - */
> -static void prism2sta_inf_handover(struct wlandevice *wlandev,
> -				   struct hfa384x_inf_frame *inf)
> -{
> -	pr_debug("received infoframe:HANDOVER (unhandled)\n");
> -}
> -
>  /*
>   * prism2sta_inf_tallies
>   *
> @@ -1724,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
>  	/* Dispatch */
>  	switch (inf->infotype) {
>  	case HFA384x_IT_HANDOVERADDR:
> -		prism2sta_inf_handover(wlandev, inf);
> +		netdev_dbg(wlandev->netdev,
> +			   "received infoframe:HANDOVER (unhandled)\n");
>  		break;
>  	case HFA384x_IT_COMMTALLIES:
>  		prism2sta_inf_tallies(wlandev, inf);
> -- 
> 2.34.1
> 
> 



Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot