linux-kernel - Re: [PATCH 2/2] tty: gdm724x: Add blank line after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231015060716.GA31326@Negi>
Date:   Sat, 14 Oct 2023 23:07:16 -0700
From:   Soumya Negi <soumya.negi97@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jonathan Kim <jonathankim@...semi.com>,
        Dean ahn <deanahn@...semi.com>, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tty: gdm724x: Add blank line after declaration

On Sun, Oct 15, 2023 at 07:37:30AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 13, 2023 at 01:26:35AM -0700, Soumya Negi wrote:
> > Fix WARNING: Missing a blank line after declarations
> > Issue found by checkpatch.pl
> > 
> > Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> > ---
> >  drivers/staging/gdm724x/gdm_tty.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Why do you have "tty:" as the prefix for a staging driver?  Shouldn't it
> be "staging: gdm724x: ...."?

Hi Greg,

Thats what I thought too. But when I looked at the git history for
gdm_tty.c the last few commits had "tty:". So I went with that.
Should I change it to "staging:"?

Regards,
Soumya

> thanks,
> 
> greg k-h