linux-kernel - Re: [PATCH] staging: wlan-ng: remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd59334-428b-4e27-8d19-7b8514bb5ef5@t-8ch.de>
Date:   Sun, 15 Oct 2023 11:24:43 +0200
From:   Thomas Weißschuh <linux@...ssschuh.net>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     Dan Carpenter <dan.carpenter@...aro.org>,
        outreachy@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Luke Koch <lu.ale.koch@...il.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Simon Horman <horms@...nel.org>, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: remove unused functions

Hi Calvince,

On 2023-10-15 10:39:20+0300, Calvince Otieno wrote:
> On Sun, Oct 15, 2023 at 10:38 AM Calvince Otieno <calvncce@...il.com> wrote:
> > On Fri, Oct 13, 2023 at 12:02 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
> >
> > On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> > > The following functions were defined in the prism2mgmt.h file but neither
> > > declared nor used anywhere. It is recommended that they be removed.
> > >
> > >       - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> > >                                     struct hfa384x *priv);
> > >       - int prism2mgmt_set_grpaddr(u32 did,
> > >                                  u8 *prism2buf, struct p80211pstrd *pstr,
> > >                                  struct hfa384x *priv);
> > >       - int prism2mgmt_get_grpaddr_index(u32 did);
> > >
> >
> > Could you look up when the functions were deleted and add that
> > information to the commit message?
> >
> >     These functions were removed five years ago in commit 123412341234
> >     ("delete functions").
> >
> > regards,
> > dan carpenter
> 
> I am  not able to locate exactly when these functions were deleted.
> I have checked the commit history of these files prism2mgmt.h and prism2mgmt.c,
> but, I can't find any commit relating to the removal of the above functions.

you can use the "-S" argument to "git log" for this quite nicely:

$ git log --pretty=oneline  -Sprism2mgmt_set_grpaddr drivers/staging/wlan-ng
1e7201836c576883d5bd708810cc72ab1392756f Staging: wlan-ng: Delete a pile of unused mibs. And fix WEXT SET_TXPOWER.
cbec30c4c00c9f5a7357f5c5dacb63ae2378afb4 Staging: wlan-ng: Delete a large pile of now-unused code.
00b3ed1685089ff52169a715de11106ed37df087 Staging: add wlan-ng prism2 usb driver

This shows all the commits that touched the drivers/staging/wlan-ng
directory and added or removed the string "prism2mgmt_set_grpadd".

You can check which of these three commits dropped the function and then
repeat the procedure for the other two functions.

Thomas