linux-kernel - [PATCH] ACPI: irq: Fix the incorrect return value in acpi_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231016170939.1192260-1-sunilvl@ventanamicro.com>
Date:   Mon, 16 Oct 2023 22:39:39 +0530
From:   Sunil V L <sunilvl@...tanamicro.com>
To:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Agustin Vega-Frias <agustinv@...eaurora.org>,
        Hanjun Guo <guohanjun@...wei.com>,
        Marc Zyngier <maz@...nel.org>,
        Anup Patel <apatel@...tanamicro.com>,
        Sunil V L <sunilvl@...tanamicro.com>
Subject: [PATCH] ACPI: irq: Fix the incorrect return value in acpi_register_gsi()

acpi_register_gsi() should return negative value in case of failure.
Currently, it returns the return value from irq_create_fwspec_mapping().
However, irq_create_fwspec_mapping() returns 0 for failure. Fix the issue
by returning -EINVAL if irq_create_fwspec_mapping() returns zero.

Fixes: d44fa3d46079 ("ACPI: Add support for ResourceSource/IRQ domain mapping")
Signed-off-by: Sunil V L <sunilvl@...tanamicro.com>
---
 drivers/acpi/irq.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c
index c2c786eb95ab..403f33df66af 100644
--- a/drivers/acpi/irq.c
+++ b/drivers/acpi/irq.c
@@ -57,6 +57,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger,
 		      int polarity)
 {
 	struct irq_fwspec fwspec;
+	unsigned int rc;
 
 	fwspec.fwnode = acpi_get_gsi_domain_id(gsi);
 	if (WARN_ON(!fwspec.fwnode)) {
@@ -68,7 +69,11 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger,
 	fwspec.param[1] = acpi_dev_get_irq_type(trigger, polarity);
 	fwspec.param_count = 2;
 
-	return irq_create_fwspec_mapping(&fwspec);
+	rc = irq_create_fwspec_mapping(&fwspec);
+	if (!rc)
+		return -EINVAL;
+
+	return rc;
 }
 EXPORT_SYMBOL_GPL(acpi_register_gsi);
 
-- 
2.39.2