linux-kernel - Re: [PATCH net v2] net: ti: icssg-prueth: Fix r30 CMDs bitmasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2023 22:26:24 +0530
From:   "Anwar, Md Danish" <a0501179@...com>
To:     Andrew Lunn <andrew@...n.ch>, MD Danish Anwar <danishanwar@...com>
CC:     Jacob Keller <jacob.e.keller@...el.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <srk@...com>, Vignesh Raghavendra <vigneshr@...com>,
        <r-gunasekaran@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix r30 CMDs bitmasks

On 10/16/2023 9:58 PM, Andrew Lunn wrote:
> On Mon, Oct 16, 2023 at 09:45:25PM +0530, MD Danish Anwar wrote:
>> The bitmask for EMAC_PORT_DISABLE and EMAC_PORT_FORWARD has been changed
>> in the ICSSG firmware REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
>>
>> The current bitmasks are wrong and as a result EMAC_PORT_DISABLE and
>> EMAC_PORT_FORWARD commands doesn not work.
>> Update r30 commands to use the same bitmask as used by the ICSSG firmware
>> REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
>>
>> These bitmasks are not backwards compatible. This will work with
>> firmware version REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05 and above but
>> not with lower firmware versions.
> 
> Breaking backwards compatibility is generally not allowed.
> 
> As far as i understand the driver, it loads whatever version of
> firmware is available. It does not ask for a specific version. So you
> should ask the firmware what version it is, and then handle the
> bitmask as appropriate.
> 

Understood. I will try to find a way to do this at runtime.

> How many different versions of REL.PRU-ICSS-ETHERNET-SWITCH have been
> released? They don't appear to be part of linux-firmware.git :-(
> 

The firmwares are currently not posted to linux-firmware.git. They are
maintained internally as of now. Different version of firmware is
released for every SDK release (3-4 times a year)

>     Andrew
> 
> ---
> pw-bot: cr

-- 
Thanks and Regards,
Md Danish Anwar