linux-kernel - Re: [PATCH v2 -next] usb/usbip: fix wrong data added to platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8328df87-67d0-43a8-aa6a-4b9587089e3a@linuxfoundation.org>
Date:   Mon, 16 Oct 2023 11:19:41 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hongren Zheng <i@...ithal.me>
Cc:     Shuah Khan <shuah@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Valentina Manea <valentina.manea.m@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfr@...b.auug.org.au, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 -next] usb/usbip: fix wrong data added to platform
 device

On 10/16/23 01:40, Andy Shevchenko wrote:
> On Sat, Oct 14, 2023 at 03:46:04PM +0800, Hongren Zheng wrote:
>> .data of platform_device_info will be copied into .platform_data of
>> struct device via platform_device_add_data.
> 
> platform_device_add_data()
> 
>> However, vhcis[i] contains a spinlock, is dynamically allocated and
>> used by other code, so it is not meant to be copied. The workaround
>> was to use void *vhci as an agent, but it was removed in the commit
>> suggested below.
>>
>> This patch adds back the workaround and changes the way of using
>> platform_data accordingly.
> 
> Good learning to me, thank you for the fix!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 

Thank you both.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah