[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231016-chatroom-regulator-a75f1d8be809@spud>
Date: Mon, 16 Oct 2023 18:30:11 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: miquel.raynal@...tlin.com, conor.culhane@...vaco.com,
alexandre.belloni@...tlin.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, joe@...ches.com,
peng.fan@....com, alexander.stein@...tq-group.com,
haibo.chen@....com, ping.bai@....com, xiaoning.wang@....com,
sherry.sun@....com, linux-i3c@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible
string
On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
> In driver, compatible string is silvaco,i3c-master instead of
> silvaco,i3c-master-v1.
And what makes the driver right & the binding wrong? AFAICT, this is an
IP sold by silvaco & the -v1 suffix was explicitly requested during
review of the binding.
Thanks,
Conor.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index 133855f11b4f..19e3f75eb45c 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -14,7 +14,7 @@ allOf:
>
> properties:
> compatible:
> - const: silvaco,i3c-master-v1
> + const: silvaco,i3c-master
>
> reg:
> maxItems: 1
> @@ -49,7 +49,7 @@ unevaluatedProperties: false
> examples:
> - |
> i3c-master@...00000 {
> - compatible = "silvaco,i3c-master-v1";
> + compatible = "silvaco,i3c-master";
> clocks = <&zynqmp_clk 71>, <&fclk>, <&sclk>;
> clock-names = "pclk", "fast_clk", "slow_clk";
> interrupt-parent = <&gic>;
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists