linux-kernel - Re: [PATCH net-next v3 1/2] net: dsa: Use conduit and user terms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231016190555.svp5rjtheogxlkzv@skbuf>
Date:   Mon, 16 Oct 2023 22:05:55 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Florian Fainelli <florian.fainelli@...adcom.com>,
        netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:ARM/Mediatek SoC support" <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v3 1/2] net: dsa: Use conduit and user terms

On Mon, Oct 16, 2023 at 09:41:35AM -0700, Florian Fainelli wrote:
> > > @@ -29,7 +29,7 @@ static inline int dsa_tag_protocol_overhead(const struct dsa_device_ops *ops)
> > >   	return ops->needed_headroom + ops->needed_tailroom;
> > >   }
> > > -static inline struct net_device *dsa_master_find_slave(struct net_device *dev,
> > > +static inline struct net_device *dsa_conduit_find_user(struct net_device *dev,
> > >   						       int device, int port)
> > 
> > Please adjust alignment.
> 
> checkpatch did not complain and my editor shows me the alignment appears to
> be proper, what am I missing?

I didn't realize that the length of "master-slave" is the same as that of "conduit-user",
sorry.

> > > diff --git a/net/dsa/tag_8021q.c b/net/dsa/tag_8021q.c
> > > index cbdfc392f7e0..71b26ae6db39 100644
> > > --- a/net/dsa/tag_8021q.c
> > > +++ b/net/dsa/tag_8021q.c
> > > @@ -468,10 +468,10 @@ struct sk_buff *dsa_8021q_xmit(struct sk_buff *skb, struct net_device *netdev,
> > >   }
> > >   EXPORT_SYMBOL_GPL(dsa_8021q_xmit);
> > > -struct net_device *dsa_tag_8021q_find_port_by_vbid(struct net_device *master,
> > > +struct net_device *dsa_tag_8021q_find_port_by_vbid(struct net_device *conduit,
> > >   						   int vbid)
> > 
> > Alignment.
> 
> Likewise.

My mistake, sorry.