linux-kernel - Re: [PATCH v2] selftests/x86/lam: Zero out buffer for readlink()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f22e0008-24da-4b6a-bdff-61bc448bf5f8@linuxfoundation.org>
Date:   Mon, 16 Oct 2023 13:11:12 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     kirill.shutemov@...ux.intel.com,
        Binbin Wu <binbin.wu@...ux.intel.com>
Cc:     dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        shuah@...nel.org, linux-kselftest@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests/x86/lam: Zero out buffer for readlink()

On 10/16/23 02:47, kirill.shutemov@...ux.intel.com wrote:
> On Mon, Oct 16, 2023 at 02:24:46PM +0800, Binbin Wu wrote:
>> Zero out the buffer for readlink() since readlink() does not append a
>> terminating null byte to the buffer.  Also change the buffer length
>> passed to readlink() to 'PATH_MAX - 1' to ensure the resulting string
>> is always null terminated.
>>
>> Fixes: 833c12ce0f430 ("selftests/x86/lam: Add inherit test cases for linear-address masking")
>>
>> Signed-off-by: Binbin Wu <binbin.wu@...ux.intel.com>
> 
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> 

Thank you. Applied to linux-kselftest next for Linux 6.7-rc1

thanks,
-- Shuah