linux-kernel - Re: [PATCH v6 0/8] Add printf attribute to kselftest functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s3wj75zwkwwmvllobuevhf7nbkhyn2a2kwis7oyt3nwsnl5j36@ju5xzn6pw5p5>
Date:   Mon, 16 Oct 2023 07:28:44 +0200
From:   Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>
To:     Shuah <shuah@...nel.org>
CC:     <akpm@...ux-foundation.org>, <christian@...lner.me>,
        <fenghua.yu@...el.com>, <keescook@...omium.org>,
        <ndesaulniers@...gle.com>, <coltonlewis@...gle.com>,
        <dmatlack@...gle.com>, <vipinsh@...gle.com>, <seanjc@...gle.com>,
        <brauner@...nel.org>, <pbonzini@...hat.com>, <hannes@...xchg.org>,
        <nphamcs@...il.com>, <reinette.chatre@...el.com>,
        <ilpo.jarvinen@...ux.intel.com>, <linux-kselftest@...r.kernel.org>,
        <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v6 0/8] Add printf attribute to kselftest functions

On 2023-10-13 at 15:03:11 -0600, Shuah wrote:
>On 10/13/23 05:36, Maciej Wieczor-Retman wrote:
>> kselftest.h declares many variadic functions that can print some
>> formatted message while also executing selftest logic. These
>> declarations don't have any compiler mechanism to verify if passed
>> arguments are valid in comparison with format specifiers used in
>> printf() calls.
>> 
>> Attribute addition can make debugging easier, the code more consistent
>> and prevent mismatched or missing variables.
>> 
>> The first patch adds __printf() macro and applies it to all functions
>> in kselftest.h that use printf format specifiers. After compiling all
>> selftests using:
>> 	make -C tools/testing/selftests
>> many instances of format specifier mismatching are exposed in the form
>> of -Wformat warnings.
>> 
>> Fix the mismatched format specifiers caught by __printf() attribute in
>> multiple tests.
>> 
>> Series is based on kselftests next branch.
>> 
>> Changelog v6:
>> - Add methodology notes to all patches.
>> - No functional changes in the patches.
>> 
>
>Applied this series and the following three - all 25 patches are
>in linux-kselftest next for Linux 6.7-rc1.
>
>[1] https://lore.kernel.org/all/cover.1696932728.git.maciej.wieczor-retman@intel.com/
>[2] https://lore.kernel.org/all/20231002094813.6633-1-ilpo.jarvinen@linux.intel.com/
>[3] https://lore.kernel.org/all/20230904095339.11321-1-ilpo.jarvinen@linux.intel.com/
>
>thanks,
>-- Shuah
>

Thank you!

-- 
Kind regards
Maciej Wieczór-Retman