linux-kernel - Re: [PATCH] fbdev: sa1100fb: mark sa1100fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ad85b24-4f7d-4031-ab27-d5c6516dff8b@gmx.de>
Date:   Mon, 16 Oct 2023 23:06:47 +0200
From:   Helge Deller <deller@....de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee@...nel.org>, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static

On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> This is a global function that is only referenced as an initcall. This causes
> a warning:
>
> drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
>
> Make it static instead.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/sa1100fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index 63e12a7c1100e..e14eb634cb944 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
>   	},
>   };
>
> -int __init sa1100fb_init(void)
> +static int __init sa1100fb_init(void)
>   {
>   	if (fb_get_options("sa1100fb", NULL))
>   		return -ENODEV;