linux-kernel - Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231016145408.539968d1@kernel.org>
Date:   Mon, 16 Oct 2023 14:54:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shinas Rasheed <srasheed@...vell.com>
Cc:     <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <egallen@...hat.com>,
        <hgani@...vell.com>, <mschmidt@...hat.com>,
        <netdev@...r.kernel.org>, <sedara@...vell.com>,
        <vburru@...vell.com>, <vimleshk@...vell.com>
Subject: Re: [net PATCH v2] octeon_ep: update BQL sent bytes before ringing
 doorbell

On Thu, 12 Oct 2023 03:17:06 -0700 Shinas Rasheed wrote:
> -	netdev_tx_sent_queue(iq->netdev_q, skb->len);
>  	iq->stats.instr_posted++;
>  	skb_tx_timestamp(skb);

The skb_tx_timestamp() here will do the same exact UAF, no?
I think you should move them both.
-- 
pw-bot: cr