linux-kernel - Re: [PATCH] staging: rtl8192u: Align descendant arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3620a5eb-34d8-49ae-a925-66f85a62e09c@kadam.mountain>
Date:   Mon, 16 Oct 2023 08:39:16 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Gilbert Adikankwu <gilbertadikankwu@...il.com>
Cc:     gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Align descendant arguments

On Sun, Oct 15, 2023 at 08:44:18AM +0100, Gilbert Adikankwu wrote:
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> index 54747fda552f..a81e88894e01 100644
> --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> @@ -46,17 +46,17 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
>  				    priv->card_8192_version == VERSION_819XU_B) {
>  					/* 8256 D-cut, E-cut, xiong: consider it later! */
>  					rtl8192_phy_SetRFReg(dev,
> -						(enum rf90_radio_path_e)eRFPath,
> -						0x0b, bMask12Bits, 0x100); /* phy para:1ba */
> +							     (enum rf90_radio_path_e)eRFPath,
> +							     0x0b, bMask12Bits, 0x100); /* phy para:1ba */

These ones go too long indented like this.  The other sections are fine
but just leave leave this file as it was.

regards,
dan carpenter

>  					rtl8192_phy_SetRFReg(dev,
> -						(enum rf90_radio_path_e)eRFPath,
> -						0x2c, bMask12Bits, 0x3d7);
> +							     (enum rf90_radio_path_e)eRFPath,
> +							     0x2c, bMask12Bits, 0x3d7);
>  					rtl8192_phy_SetRFReg(dev,
> -						(enum rf90_radio_path_e)eRFPath,
> -						0x0e, bMask12Bits, 0x021);
> +							     (enum rf90_radio_path_e)eRFPath,
> +							     0x0e, bMask12Bits, 0x021);
>  					rtl8192_phy_SetRFReg(dev,
> -						(enum rf90_radio_path_e)eRFPath,
> -						0x14, bMask12Bits, 0x5ab);
> +							     (enum rf90_radio_path_e)eRFPath,
> +							     0x14, bMask12Bits, 0x5ab);
>  				} else {
>  					RT_TRACE(COMP_ERR, "%s(): unknown hardware version\n", __func__);
>  					}