linux-kernel - Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231016080544.45778-1-wangweidong.a@awinic.com>
Date:   Mon, 16 Oct 2023 16:05:44 +0800
From:   wangweidong.a@...nic.com
To:     krzysztof.kozlowski@...aro.org
Cc:     13916275206@....com, alsa-devel@...a-project.org, arnd@...db.de,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        dan.carpenter@...aro.org, devicetree@...r.kernel.org,
        fido_max@...ox.ru, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, rf@...nsource.cirrus.com,
        robh+dt@...nel.org, ryans.lee@...log.com,
        sebastian.reichel@...labora.com, shumingf@...ltek.com,
        tiwai@...e.com, trix@...hat.com, wangweidong.a@...nic.com,
        yijiangtao@...nic.com
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

Thank you very much for your review

On 13/10/2023 13:50, +200 krzysztof.kozlowski@...aro.org wrote:
> On 13/10/2023 12:42, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Add i2c and amplifier registration for
>> aw88399 and their associated operation functions.
>> 


>> +
>> +static void aw88399_hw_reset(struct aw88399 *aw88399)
>> +{
>> +	if (aw88399->reset_gpio) {
>> +		gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
>> +		usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
>> +		gpiod_set_value_cansleep(aw88399->reset_gpio, 1);

> Why do you leave the device in reset state? I think you wanted these
> reverted.

our chip is reset at low level, So I'll change it to
    gpiod_set_value_cansleep(aw88399->reset_gpio, 1);
	usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
	gpiod_set_value_cansleep(aw88399->reset_gpio, 0);
	usleep_range(AW88399_1000_US, AW88399_1000_US + 10);
	gpiod_set_value_cansleep(aw88399->reset_gpio, 1);
Thanks again for your advice.

Best regards,
Weidong Wang