[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZSzwbmE_grD-giRp@hovoldconsulting.com>
Date: Mon, 16 Oct 2023 10:12:30 +0200
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Johan Hovold <johan+linaro@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-x13s: Use the correct DP PHY
compatible
On Mon, Oct 02, 2023 at 10:54:57AM +0200, Johan Hovold wrote:
> On Fri, Sep 29, 2023 at 06:02:57PM +0200, Konrad Dybcio wrote:
> > The DP PHY needs different settings when an eDP display is used.
> > Make sure these apply on the X13s.
>
> Good catch. This looks to be more in line with what Bjorn intended.
>
> You should fix up sc8280xp-crd and sa8295p-adp.dts as well however.
As we discussed off-list, some of the ADP DP PHYs are apparently just
confusingly named "eDP" for some reason so that does not need fixing.
I sent a fix for the CRD here:
https://lore.kernel.org/all/20231016080658.6667-1-johan+linaro@kernel.org/
> > &mdss0_dp3_phy {
> > + compatible = "qcom,sc8280xp-edp-phy";
>
> Nit: Can you add a newline here after the compatible, please?
Would you mind respinning this one with an added newline here for
consistency, though?
> > vdda-phy-supply = <&vreg_l6b>;
> > vdda-pll-supply = <&vreg_l3b>;
Johan
Powered by blists - more mailing lists