[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <453d929b-0d6d-4e52-aa7f-454bbf4cac7c@xs4all.nl>
Date: Mon, 16 Oct 2023 10:22:45 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Benjamin Gaignard <benjamin.gaignard@...labora.com>,
mchehab@...nel.org, tfiga@...omium.org, m.szyprowski@...sung.com,
ming.qian@....com, ezequiel@...guardiasur.com.ar,
p.zabel@...gutronix.de, gregkh@...uxfoundation.org,
nicolas.dufresne@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
kernel@...labora.com, Dmitry Torokhov <dmitry.torokhov@...il.com>,
Henrik Rydberg <rydberg@...math.org>
Subject: Re: [PATCH v11 39/56] touchscreen: sur40: Stop direct calls to queue
num_buffers field
On 12/10/2023 13:46, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> CC: Dmitry Torokhov <dmitry.torokhov@...il.com>
> CC: Henrik Rydberg <rydberg@...math.org>
> ---
> drivers/input/touchscreen/sur40.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index 8ddb3f7d307a..e7d2a52169a0 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -847,9 +847,10 @@ static int sur40_queue_setup(struct vb2_queue *q,
> unsigned int sizes[], struct device *alloc_devs[])
> {
> struct sur40_state *sur40 = vb2_get_drv_priv(q);
> + unsigned int q_num_bufs = vb2_get_num_buffers(q);
>
> - if (q->num_buffers + *nbuffers < 3)
> - *nbuffers = 3 - q->num_buffers;
> + if (q_num_bufs + *nbuffers < 3)
> + *nbuffers = 3 - q_num_bufs;
This can just be dropped since this driver sets min_buffers_needed to 3.
Regards,
Hans
>
> if (*nplanes)
> return sizes[0] < sur40->pix_fmt.sizeimage ? -EINVAL : 0;
Powered by blists - more mailing lists