linux-kernel - Re: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93dcb9f6f218593084f834ba6b450999@vanmierlo.com>
Date:   Mon, 16 Oct 2023 10:46:44 +0200
From:   m.brock@...mierlo.com
To:     Florian Eckert <fe@....tdt.de>
Cc:     Eckert.Florian@...glemail.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, pavel@....cz, lee@...nel.org,
        kabel@...nel.org, u.kleine-koenig@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-leds@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to
 the top

Florian Eckert wrote on 2023-10-16 09:13:
> Has complained about the following construct:

Who is "Has" or who/what has complained?

> drivers/leds/trigger/ledtrig-tty.c:362:3: error: a label can only be
> part of a statement and a declaration is not a statement
> 
> Hence move the variable definition to the beginning of the function.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/
> Signed-off-by: Florian Eckert <fe@....tdt.de>
> ---
> @@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct 
> *work)
> 
>  	if (icount.rx != trigger_data->rx ||
>  	    icount.tx != trigger_data->tx) {
> -		unsigned long interval = LEDTRIG_TTY_INTERVAL;
> -

Is this kernel test robot broken?
I see no label definition here.
And this variable declaration is at the start of a new block which does 
not
even require C99 support.

>  		led_blink_set_oneshot(trigger_data->led_cdev, &interval,
>  				      &interval, 0);

Maarten