linux-kernel - Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2023 17:07:54 +0800
From:   wangweidong.a@...nic.com
To:     wangweidong.a@...nic.com
Cc:     13916275206@....com, alsa-devel@...a-project.org, arnd@...db.de,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        dan.carpenter@...aro.org, devicetree@...r.kernel.org,
        fido_max@...ox.ru, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, rf@...nsource.cirrus.com,
        robh+dt@...nel.org, ryans.lee@...log.com,
        sebastian.reichel@...labora.com, shumingf@...ltek.com,
        tiwai@...e.com, trix@...hat.com, yijiangtao@...nic.com
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver

I'm very sorry that I misunderstood my last comment, correct it here.
Thank you again for you hard review.

On Mon, Oct 16, 2023 at 16:10:17 +0800, wangweidong.a@...nic.com wrote
> On Fri, Oct 13, 2023 at 03:10:56 PM +0100, broonie@...nel.org wrote:
>> On Fri, Oct 13, 2023 at 06:42:20PM +0800, wangweidong.a@...nic.com wrote:

>> This looks good - some *very* minor comments below.


>>> +static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
>>> +			unsigned char *data, unsigned int len, unsigned short base)
>>> +{
>>> +	int i, ret;
>>> +
>>> +#ifdef AW88399_DSP_I2C_WRITES
>>> +	u32 tmp_len;

>> This looks like debug code which can hopefully be removed in favour of
>> the regmap implementation?

> Thank you very much, but this is not a debugging statement, This is designed
> to be compatible with different platforms that may not support continuous
> writing.

I found "use_single_write" in regmap, I will remove "AW88399_DSP_I2C_WRITES".

Best regards,
Weidong Wang