linux-kernel - Re: [PATCH net-next,v2] cgroup, netclassid: on modifying netclassid in cgroup, only consider the main process.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231016092832.GI1501712@kernel.org>
Date:   Mon, 16 Oct 2023 11:28:32 +0200
From:   Simon Horman <horms@...nel.org>
To:     Liansen Zhai <zhailiansen@...il.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, yuwang@...ishou.com,
        wushukun@...ishou.com, Liansen Zhai <zhailiansen@...ishou.com>
Subject: Re: [PATCH net-next,v2] cgroup, netclassid: on modifying netclassid
 in cgroup, only consider the main process.

On Thu, Oct 12, 2023 at 05:03:30PM +0800, Liansen Zhai wrote:
> When modifying netclassid, the command("echo 0x100001 > net_cls.classid")
> will take more time on many threads of one process, because the process
> create many fds.
> for example, one process exists 28000 fds and 60000 threads, echo command
> will task 45 seconds.
> Now, we only consider the main process when exec "iterate_fd", and the
> time is about 52 milliseconds.
> 
> Signed-off-by: Liansen Zhai <zhailiansen@...ishou.com>

Thanks for addressing my review of v1.

Reviewed-by: Simon Horman <horms@...nel.org>