linux-kernel - Re: [PATCH] soundwire: bus: improve error handling for clock stop prepare/deprepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2023 16:50:51 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     alsa-devel@...a-project.org,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
Cc:     vinod.koul@...aro.org, linux-kernel@...r.kernel.org,
        pierre-louis.bossart@...ux.intel.com, bard.liao@...el.com
Subject: Re: [PATCH] soundwire: bus: improve error handling for clock stop
 prepare/deprepare


On Fri, 13 Oct 2023 09:08:12 +0800, Bard Liao wrote:
> The same logic is used for clock stop prepare and deprepare, and
> having different logs for the two steps helps identify problems.
> 
> In addition, when the "NotFinished" bit remains set, the error
> handling is not quite right:
> 
> a) for the clock stop prepare, the error is handled at the caller
> level, and the error is ignored: there's no good reason to prevent the
> pm_runtime suspend from happening. Throwing an error that is later
> ignored is confusing.
> 
> [...]

Applied, thanks!

[1/1] soundwire: bus: improve error handling for clock stop prepare/deprepare
      commit: ff435da4cc8b6137be9f0b6b4a9af095590d4b8c

Best regards,
-- 
~Vinod