linux-kernel - Re: [PATCH 2/3] serial: core: Make local variable size to u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0ec67b1-24a2-d67d-d7c1-9c3fdafdb570@linux.intel.com>
Date:   Mon, 16 Oct 2023 14:39:23 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Vamshi Gajjela <vamshigajjela@...gle.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, manugautam@...gle.com,
        Subhash Jadavani <sjadavani@...gle.com>,
        Channa Kadabi <kadabi@...gle.com>
Subject: Re: [PATCH 2/3] serial: core: Make local variable size to u64

On Sat, 14 Oct 2023, Vamshi Gajjela wrote:

> From: VAMSHI GAJJELA <vamshigajjela@...gle.com>
> 
> The variable size has been changed from u32 to u64 to accommodate a
> larger range of values without the need for explicit typecasting.

Don't use too broad/generic terminology in shortlog (on [PATCH] line in 
subject) or changelog but explicitly mention the variable names please.

> Signed-off-by: VAMSHI GAJJELA <vamshigajjela@...gle.com>
> ---
>  drivers/tty/serial/serial_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 7bdc21d5e13b..fb4696d17a8b 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -410,10 +410,10 @@ void
>  uart_update_timeout(struct uart_port *port, unsigned int cflag,
>  		    unsigned int baud)
>  {
> -	unsigned int size = tty_get_frame_size(cflag);
> +	u64 size = tty_get_frame_size(cflag);
>  	u64 frame_time;
>  
> -	frame_time = (u64)size * NSEC_PER_SEC;
> +	frame_time = size * NSEC_PER_SEC;
>  	port->frame_time = DIV64_U64_ROUND_UP(frame_time, baud);
>  }
>  EXPORT_SYMBOL(uart_update_timeout);

This is actually a good cleanup all by itself unrelated to the other 
change but you need to adapt the changelog to reflect why this is helpful 
instead wording it based on the other change.

-- 
 i.