linux-kernel - Re: [PATCH 0/5] Fix page_owner's use of free timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2023 07:55:18 -0400
From:   Rafael Aquini <aquini@...hat.com>
To:     Audra Mitchell <audra@...hat.com>
Cc:     linux-mm@...ck.org, raquini@...hat.com, akpm@...ux-foundation.org,
        djakov@...nel.org, vbabka@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Fix page_owner's use of free timestamps

On Fri, Oct 13, 2023 at 03:03:44PM -0400, Audra Mitchell wrote:
> While page ower output is used to investigate memory utilization, typically
> the allocation pathway, the introduction of timestamps to the page owner 
> records caused each record to become unique due to the granularity of the
> nanosecond timestamp (for example):
> 
>   Page allocated via order 0 ... ts 5206196026 ns, free_ts 5187156703 ns
>   Page allocated via order 0 ... ts 5206198540 ns, free_ts 5187162702 ns
> 
> Furthermore, the page_owner output only dumps the currently allocated 
> records, so having the free timestamps is nonsensical for the typical use 
> case.
> 
> In addition, the introduction of timestamps was not properly handled in
> the page_owner_sort tool causing most use cases to be broken. This series
> is meant to remove the free timestamps from the page_owner output and
> fix the page_owner_sort tool so proper collation can occur.
> 
> Audra Mitchell (5):
>   mm/page_owner: Remove free_ts from page_owner output
>   tools/mm: Remove references to free_ts from page_owner_sort
>   tools/mm: Filter out timestamps for correct collation
>   tools/mm: Fix the default case for page_owner_sort
>   tools/mm: Update the usage output to be more organized
> 
>  mm/page_owner.c            |   4 +-
>  tools/mm/page_owner_sort.c | 212 +++++++++++++++++--------------------
>  2 files changed, 100 insertions(+), 116 deletions(-)
> 
> -- 
> 2.41.0
> 

Thank you, Audra.

Acked-by: Rafael Aquini <aquini@...hat.com>